Windows: Sync hosts dir with proper permissions #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fullyint
force-pushed
the
hosts-sync
branch
3 times, most recently
from
21417f0
to
810e080
Compare
|
This PR simplifies the command at the end of - ansible-playbook ${ANSIBLE_PATH}/dev.yml -i ${TEMP_HOSTS}/development --sudo --user=vagrant --connection=local
+ ansible-playbook dev.yml
|
fullyint
force-pushed
the
hosts-sync
branch
2 times, most recently
from
5239366
to
ecc0bda
Compare
|
This PR originally synced the |
| @@ -51,6 +51,7 @@ Vagrant.configure('2') do |config| | |||
| end | |||
|
|
|||
| if Vagrant::Util::Platform.windows? | |||
| config.vm.synced_folder '.', '/vagrant', mount_options: ['dmode=776', 'fmode=664'] | |||
There was a problem hiding this comment.
Doesn't this mean that deploy.sh won't execute now?
|
@QWp6t correctly pointed out that |
|
Just tested this. It works. 👍 |
fullyint
added a commit
that referenced
this pull request
Jan 17, 2016
Windows: Sync hosts dir with proper permissions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To run Ansible commands directly, Windows users have had to adjust permissions for files in the synced
hostsdirectory. This PR implements @QWp6t's approach of syncinghostswith the proper permissions.I bumped the Vagrant requirement to 1.8 to take advantage of the shell provisioner's new
envoption which enables us to pass theANSIBLE_PATH_ON_VMtowindows.sh.Could a Windows user test and confirm that this works?